Ce/async api #2
Open
Ce/async api #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These methods use sendMethodCall() which in turn is non-const. Signed-off-by: Christian Eggers <[email protected]>
warning: type qualifiers ignored on cast result type [-Wignored-qualifiers] Signed-off-by: Christian Eggers <[email protected]>
warning: cast from type ‘const uint8_t*’ {aka ‘const unsigned char*’} to
type ‘uint32_t*’ {aka ‘unsigned int*’} casts away qualifiers
[-Wcast-qual]
Signed-off-by: Christian Eggers <[email protected]>
warning: comparison of integer expressions of different signedness:
‘int’ and ‘std::__cxx11::basic_string<char>::size_type’ {aka ‘unsigned
int’} [-Wsign-compare]
Signed-off-by: Christian Eggers <[email protected]>
warning: cast from type ‘const uint32_t*’ {aka ‘const unsigned int*’} to
type ‘char*’ casts away qualifiers [-Wcast-qual]
Use C++ style cast.
Signed-off-by: Christian Eggers <[email protected]>
warning: ISO C++ forbids variable length array ‘fdbuf’ [-Wvla] Signed-off-by: Christian Eggers <[email protected]>
I get the following compiler errors when I only include dbus_connection.h: error: ‘WellKnownName’ does not name a type error: ‘MatchRule’ does not name a type error: ‘MatchRule’ was not declared in this scope error: template argument 1 is invalid ... error: request for member ‘str’ in ‘rule’, which is of non-class type ‘const int’ ... Header files should be mostly self contained. Signed-off-by: Christian Eggers <[email protected]>
Required if dbus-asio is included via add_subdirectory() Signed-off-by: Christian Eggers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Heiko,
here are some trivial fixes for your async_api branch. Feel free to modify them,
cherry-pick individual commits or even fixup your own commits.
It is unlikely that I will find time for further improvements as I have to migrate
away to GDBus due to licensing issues.
regards
Christian