v10.5.0 (#176)

* Clean up

* Fixing MinTacticalPointsCondition

* Adding the ability to toggle Gambits on and off temporarily

* Adding ConfigItem dependencies to reload dependencies when another item changes

* Fixing nil exception in ConfigEditor

* Adding default Gambits for Sholar trust and TrustSettings migration

* Adding menu to view default job gambits

* Adding default Samurai trust Gambits

* Cleanup of Samurai

* Fixing nil exception

* Safe Rolling for COR (#139)

* Safe Rolling for COR

* Update cylibs/entity/jobs/COR.lua

* Fixing MaxTacticalPointsCondition

* Refactoring default Corsair trust behavior into Gambits

* Refactoring BattleStatTracker to use MeleeAccuracyCondition

* Cleanup

* Allowing both main job trust and sub job trust to have Gambiter role and moving Dark Knight trust drain logic to Gambits

* Updating default DRK trust settings

* Guarding for nil case in Gambiter

* Fixing regression in PickerView

* Adding PetHitPointsPercentageCondition and moving base Dragoon trust logic to Gambits

* Adding NumResistsCondition and refactoring base Puppetmaster Trust logic into Gambits

* Moving base Red Mage Trust behavior to Gambits

* Adding empty GambitSettings

* Fixing issue with stale player index in Conditions

* Fixing Min and MaxTacticalPointsCondition target index

* Nil fix

* Fixing target index issue with HP, MP and TP conditions

* More fixes

* Various fixes

* Fixing SkillchainPropertyCondition serialize

* Fixing more conditions

* Fixing nil issue with HasBuffsCondition

* Displaying friendly descriptions in conditions picker view

* Fixing Puppetmaster trust

* Updating default Gambits for White Mage and Dark Knight trusts

* Changing Gambit ability condtions check to always be player

* Adding support for capitalizing letters in text input view

* Adding Condition target filtering

* Adding Reset button to GambitSettingsMenuItem to reset to Default Gambits

* Adding replacement for AutoControl

* Adding default attachment sets for Puppetmaster Trust

* Bumping Trust version to 10.0.0

* PR feedback

* Fixing nil exception

* Fixing sleeper and adding more monster abilities to ready and finish ability condition

* Bumping Trust version to 10.0.1

* Fixing issue with equipping automaton attachments

* Adding additional delay after removing attachments

* Adding manifest.json

* Bumping Trust version to 10.0.3

* Adding the Trust MSI

* Updating MSI

* Bumping Trust version to 10.0.5

* Bumping manifest version

* Update README.md

* Adding new C# installer

* Update README.md

* Update README.md

* Create README.md

* Adding README and TrustInstaller zip file

* Adding README

* Update README.md

* Updating the TrustInstaller.zip

* Updating TrustInstaller.zip

* Updating the TrustInstaller

* Bumping Trust Version to 10.0.9

* Adding support for Entrust + Indicolure in Gambit picker

* Adding check for extra song instrument while singing dummy songs

* Fixing singer view selection

* Update README.md

* Adding Bard song diagnostics

* Adding tags field to Gambit

* Adding support for no sub job

* Disabling sub job menu item when no sub job is present

* Bumping Trust version to 10.1.0

* PR feedback

* Adding Reactions menu item

* Updating default Red Mage trust settings

* Updating default widget positions

* Fixing false positive in Bard trust diagnostics

* PR feedback

* WIP of speed singing

* Getting rid of extra multiplier on Marcato duration

* Adding StepTracker and HasDazeCondition

* Adding Command Gambit ability

* Adding // trust sc mintp command

* Adding elemental resistances

* Collapsing debuffs section of target widget when there are no debuffs

* Target widget cleanup

* Clean up

* Moving turn to face mob out of action queue

* Adding new actions

* Adding GridLayout

* Showing and disabling spells and job abilities which are unavailable on sub job

* Adding more resistance data to monster families

* Adding shortcuts for menus and widgets

* Adding shortcut for gambits

* Adding shortcut for skillchains menu

* Fixing nil issue

* Fixing nil exception in SongTracker

* Fixing regression with Gambits

* Adding missing __eq function to RunTo and RunAway

* Disabling singing while moving

* Updating default Bard trust settings and fixing song editor to respect current mode

* Fixing nil issue with ConfigEditor

* Fixing more focus issues

* Bumping Trust version to 10.2.0

* PR feedback

* Updating deafult alter egos and pull targets

* Adding more pull targets

* Updating default widget positions

* Updating release notes

* Updating manifest

* Update create_release.yml

* Updating TrustInstaller

* Updating manifest.json

* Update README.md

* Update README.md

* Updating manifest.json

* Fixing singer regressions

* Disabling keyboard shortcuts while chat is open

* Adding rolls viwe

* Adding Geomancy view

* Fixing edge case with Shooter

* Adding separate queue for equipping automaton attachments

* Disabling AutoPetMode while equipping attachments

* Fixing issue where ManeuverMode would be overriden by settings

* Overhauled AutomatonSettingsMenuItem and added abilty to customize maneuvers

* Updating help text for maneuver menu.

* Updating ManeuverMode help text

* Removing res.items dependency on PUP job file

* PR feedback

* Adding TODO

* Fixing regression in SongSettingsMenuItem

* Bumping Trust version to 10.2.1

* Fixing merge issue in manifest.json

* Adding PetStatusWidget

* Adding AutomatonStatusWidget

* Updating PetMode on AutomatonStatusWidget when changing attachments

* Removing debug error

* Bumping Trust version to 10.2.2

* Updating AutomatonStatusWidget text formatting

* Fixing scrolling content offset with section header views

* Adding pet ability in AutomatonStatusWidget

* Updating default position for pet status widget

* Updating default attachment set for LightTank

* Re-enabling AutoFaceMobMode while singing because turn to face mob is no longer in action queue

* Fixing copy on GambitSettingsMenuItem reset button

* Adding Default and Gambits for Rune Fencer

* Adding PathWidget

* Adding TargetNameCondition

* Fixing nil exception in PathRecorder

* Fixing nil exception in PathRecorder

* Adding new IPC messages

* Fixing self targeting weapon skills and nil exception with job abilities

* Updating release notes for 10.3.0

* PR feedback

* Bumping Trust version to 10.3.1

* Adding autocomplete for Trust commands

* Resetting content offset of autocomplete when menu disappears

* Removing ActionBatchingMode

* Adding MigrationManager and migration to move Bard job settings under SongSettings key

* Updating default Bard job settings file

* Adding menu to pick pianissimo songs

* Refactoring commands into GeneralCommands and MenuCommands and adding settings.xml flag to disable autocomplete

* Showing command description in info bar

* PR feedback

* Fixing missing handle_stop issue

* Fixing issue where no pianissimo song is initially selected

* Adding pianissimo songs to SongSettingsEditor

* Updating description for AutoClarionCallMode

* Fixing issue reordering Pianissimo songs

* Adding Soul Voice as a conflicting buff for Marcato

* Updating release notes

* PR feedback

* Adding menu for editing the remote commands whitelist

* Update migration_v1.lua

* Fixing issue where Bard settings migration ran on all jobs

* PR feedback

* Fixing merge issue

* PR feedback

* Fixing issue where EarthSpirit would not be dismissed

* Fixing issue where BloodPactSettings default ability would not appear selected

* Adding Puller role if neither main nor sub job Trust can pull

* Clean up

* Fixing spell, job ability and weapon skill actions for JP players

* Fixing strategem actions for JP players

* PR feedback

* PR feedback

* Updating release notes

* Adding CombatSkillsCondition and updating Hasso to only be used with 2-handed weapons

* Fixing issue where pull distance can't be edited in the UI

* Bumping Trust version to 10.4.5

* Updating default Samurai job settings file

* Adding MagicBurstTrustCommands and NukeTrustCommands

* Adding NukeCommands

* Fixing issue where Scholar menu does not refresh when changing arts

* Bumping Trust version to 10.4.6

* Adding nil check in party mob update packet

* Updating release notes

* Adding MultiPickerConfigItem

* PR feedback

* Edge cases for Truster

* Fixing nil error

* Remove sleep debuff when attacking a monster

* Fixing issue with casting spell on dead enemy

* Adding JobCondition to match multiple jobs

* Fixing PLD Gambits

* Updating default Gambits for Dancer

* Adding Apururu to cylibs/res/trusts.lua

* Bumping Trust version to 10.4.8

* Filtering out Gambit ability targets if job has no abilities for that target type

* Fixing typo in EnemiesNearbyCondition

* Updating manifest.json

* Bumping Trust version to 10.4.9

* Fixing TargetNameCondition

* Bumping Trust version to 10.5.0

* PR feedback

---------

Co-authored-by: furiex-ffxi <[email protected]>

Trust.lua

@@ -1,7 +1,7 @@
 _addon.author = 'Cyrite'
 _addon.commands = {'Trust','trust'}
 _addon.name = 'Trust'
-_addon.version = '10.4.9'
+_addon.version = '10.5.0'
 _addon.release_notes = [[
 This update introduces new menus for Bard, autocomplete for Trust
 commands, new commands and important bug fixes for users running the

cylibs/conditions/target_name.lua

@@ -18,8 +18,18 @@ function TargetNameCondition.new(name)
 end
 
 function TargetNameCondition:is_satisfied(target_index)
-    local target = windower.ffxi.get_mob_by_index(target_index)
-    if target and target.name == name then
+    local target
+    if target_index == windower.ffxi.get_player().index then
+        if windower.ffxi.get_player().target_index then
+            target = windower.ffxi.get_mob_by_index(windower.ffxi.get_player().target_index)
+        end
+    else
+        local enemy = player.party:get_target_by_index(target_index)
+        if enemy then
+            target = enemy.current_target
+        end
+    end
+    if target and target.name == self.name then
         return true
     end
     return false
@@ -34,11 +44,11 @@ function TargetNameCondition:tostring()
 end
 
 function TargetNameCondition.description()
-    return "Targeting a specific enemy."
+    return "Targeting mob with name."
 end
 
 function TargetNameCondition.valid_targets()
-    return S{ Condition.TargetType.Enemy }
+    return S{ Condition.TargetType.Self, Condition.TargetType.Enemy }
 end
 
 function TargetNameCondition:serialize()

manifest.json

@@ -1,4 +1,4 @@
 {
-  "version": "10.4.9",
-  "download_url": "https://github.com/cyritegamestudios/trust/releases/download/v10.4.9/trust.zip"
+  "version": "10.4.8",
+  "download_url": "https://github.com/cyritegamestudios/trust/archive/refs/heads/alpha.zip"
 }