Merge pull request #1819 from MetRonnie/event-bus

Clean up event listener; fix warning in test
cylc · Jun 18, 2024 · edd69f8 · edd69f8
2 parents 4f2de6a + 87d8e88
commit edd69f8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/components/cylc/workspace/Widget.vue b/src/components/cylc/workspace/Widget.vue
@@ -25,7 +25,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 </template>
 
 <script setup>
-import { provide, readonly, ref } from 'vue'
+import { onBeforeUnmount, provide, readonly, ref } from 'vue'
 import { eventBus } from '@/services/eventBus'
 
 const props = defineProps({
@@ -50,4 +50,8 @@ provide('animResetTime', readonly(animResetTime))
 eventBus.on(`lumino:show:${props.id}`, () => {
   animResetTime.value = Date.now()
 })
+
+onBeforeUnmount(() => {
+  eventBus.off(`lumino:show:${props.id}`)
+})
 </script>
diff --git a/tests/unit/components/cylc/gscan/gscan.vue.spec.js b/tests/unit/components/cylc/gscan/gscan.vue.spec.js
@@ -16,9 +16,7 @@
  */
 
 import { mount } from '@vue/test-utils'
-import { createStore } from 'vuex'
 import { createVuetify } from 'vuetify'
-import storeOptions from '@/store/options'
 import GScan from '@/components/cylc/gscan/GScan.vue'
 import CommandMenuPlugin from '@/components/cylc/commandMenu/plugin'
 import {
@@ -49,12 +47,6 @@ function filterNodes (wrapper, filteredOutNodesCache) {
 }
 
 describe('GScan component', () => {
-  const store = createStore(storeOptions)
-  const resetState = () => {
-    store.commit('workflows/SET_WORKFLOW_NAME', null)
-  }
-  beforeEach(resetState)
-
   describe('Sorting', () => {
     it('sets workflow sort order by status', () => {
       // for each worflow state ...