briandilley#305: mark com.googlecode.jsonrpc4j.JsonRpcServer#handle(j…

…avax.portlet.ResourceRequest, javax.portlet.ResourceResponse) as deprecated Added @deprecated marker and wrote a comment in the Javadoc Signed-off-by: cyb3r4nt <[email protected]>
cyb3r4nt · Jan 19, 2023 · e9fda1d · e9fda1d
1 parent 3706d07
commit e9fda1d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/build.gradle b/build.gradle
@@ -93,7 +93,7 @@ dependencies {
     implementation 'net.iharder:base64:2.3.9'
     implementation "org.slf4j:slf4j-api:${slf4jVersion}"
 
-
+    // TODO: remove deprecated portlet-api when support is removed from the code
     servletSupportImplementation 'javax.portlet:portlet-api:3.0.1'
     servletSupportImplementation 'javax.servlet:javax.servlet-api:4.0.1'
 

diff --git a/src/main/java/com/googlecode/jsonrpc4j/JsonRpcServer.java b/src/main/java/com/googlecode/jsonrpc4j/JsonRpcServer.java
@@ -74,12 +74,17 @@ public JsonRpcServer(Object handler) {
 	}
 
 	/**
-	 * Handles a portlet request.
+	 * (Deprecated) Handles a portlet request.
+	 * <p>
+	 * Note: this method is marked for removal.
+	 * Please use {@link JsonRpcBasicServer#handleRequest(InputStream, OutputStream)} instead,
+	 * and propagate request and response data streams to it.
 	 *
 	 * @param request  the {@link ResourceRequest}
 	 * @param response the {@link ResourceResponse}
 	 * @throws IOException on error
 	 */
+	@Deprecated
 	public void handle(ResourceRequest request, ResourceResponse response) throws IOException {
 		logger.debug("Handing ResourceRequest {}", request.getMethod());
 		response.setContentType(contentType);