allow fifo task execution #49
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@cyanfish I made the threadpool for the listeners configurable as it seemed to matter in load/stress testing in my use case to bump it up. |
| @@ -32,11 +33,12 @@ public NamedPipeServer(string pipeName, NamedPipeServerOptions options) | |||
| { | |||
| } | |||
|
|
|||
| internal NamedPipeServer(string pipeName, NamedPipeServerOptions options, Action<string> log) | |||
| public NamedPipeServer(string pipeName, NamedPipeServerOptions options, Action<string> log) | |||
| /// Gets or sets a count of threads to use for the listener. | ||
| /// If you need to address a synchronous code execution issue, try increasing | ||
| /// </summary> | ||
| public int ThreadPoolSize { get; set; } = 4; |
There was a problem hiding this comment.
Are you sure this helps? In general the listener thread pool is sitting idle and whenever a connection is established, immediately hands off to a task on a different thread and goes back to idling. You shouldn't need a ton of threads to be able to handle that.
If there is a problem it's presumably in high-contention scenarios where clients have trouble connecting, but in that scenario I would rather make improvements to client connection reliability that work out of the box rather than adding a knob that needs to be tuned.
| @@ -10,8 +10,11 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="Grpc.AspNetCore" Version="2.49.0" Condition="'$(TargetFramework)' != 'net462'" /> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" /> | |||
| <PackageReference Include="xunit.runner.visualstudio" Version="2.4.1" /> | |||
| <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" /> | |||
There was a problem hiding this comment.
Let's leave package version updates out of this PR unless they're needed for some reason
Expose task factory as a server context option so that FIFO task queue can be used.
Address false error on disconnect.