Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix some comments #8728

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

jingchanglu
Copy link

@jingchanglu jingchanglu commented Sep 19, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

fix some comments

Signed-off-by: jingchanglu <[email protected]>
@jingchanglu jingchanglu requested a review from a team as a code owner September 19, 2024 11:33
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 11:34am

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant