Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Use load meta with user change for SQL generation calls #8693

Merged
merged 4 commits into from
Sep 12, 2024

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Sep 11, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

Use same meta for both SQL generation and execution calls

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 98.75000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.60%. Comparing base (95beaa4) to head (3b8d463).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/test/mod.rs 89.65% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8693      +/-   ##
==========================================
+ Coverage   82.59%   82.60%   +0.01%     
==========================================
  Files         210      211       +1     
  Lines       77175    77237      +62     
==========================================
+ Hits        63740    63803      +63     
+ Misses      13435    13434       -1     
Flag Coverage Δ
cubesql 82.60% <98.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Sep 12, 2024 0:27am

@mcheshkov mcheshkov marked this pull request as ready for review September 12, 2024 10:26
@mcheshkov mcheshkov requested a review from a team as a code owner September 12, 2024 10:26
@mcheshkov mcheshkov merged commit 0f7bb3d into master Sep 12, 2024
65 checks passed
@mcheshkov mcheshkov deleted the sql-generation-user-change branch September 12, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants