Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for coord adding nonexistent user #456

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

joshualiao
Copy link

In model.py, added a check to see if the user is a coordinator in the course.

Refactored the coordinator add when the student is not in the course. It now has the following functionality:

  • If the student is a non-existent user and the course is not restricted, create a new user and enroll.
  • If the student does exist, ensure they aren't associated with the course and the course is not restricted, then enroll them.

@joshualiao joshualiao changed the title fix for coord adding nonexistent user (in process) fix for coord adding nonexistent user Nov 7, 2023
@joshualiao joshualiao changed the title (in process) fix for coord adding nonexistent user fix for coord adding nonexistent user Nov 28, 2023
@smartspot2
Copy link
Member

What's the status on this PR? Some of the more recent changes in master should fix some of the Cypress issues I think you were having.

Additionally, there are some syntax errors when the current code is run (check the changes in views/section.py), which should be fixed before this is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants