Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run git config instead of reading config file manually #639

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Run git config instead of reading config file manually #639

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/resolvers/git.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,10 +351,7 @@ module Shards
end

private def valid_repository?
File.each_line(File.join(local_path, "config")) do |line|
return true if line =~ /mirror\s*=\s*true/
end
false
capture("git config --get-regexp 'remote\\..+\\.mirror'").each_line.any?(&.==("true"))
end

private def origin_url
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we can do something similar to origin_url then to fix the problem related to #628?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this should work similarly.

Expand Down
Loading