Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip OpenSSL spec on aarch64-linux-gnu #15006

Closed
wants to merge 1 commit into from
Closed

Skip OpenSSL spec on aarch64-linux-gnu #15006

wants to merge 1 commit into from

Conversation

straight-shoota
Copy link
Member

@straight-shoota straight-shoota commented Sep 17, 2024 •
edited
Loading

This is a workaround for #15005 to avoid crashing the spec process from OpenSSL specs.

@straight-shoota straight-shoota self-assigned this Sep 17, 2024
beta-ziliani
beta-ziliani reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@beta-ziliani beta-ziliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is needed the check for OPENSSL_VERSION?

@straight-shoota
Copy link
Member Author

So far the failure has only appeared with libssl version 1.1.1. Later versions such as 1.1.1f seem to be not affected, so we can use them to run specs.

@straight-shoota
Copy link
Member Author

We probably don't need this anymore with #15007 as another workaround.
It might technically still be useful when running specs in other situations. However, we still don't understand the exact conditions for #15005 anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beta-ziliani beta-ziliani beta-ziliani left review comments

Assignees

@straight-shoota straight-shoota

Labels
kind:specs platform:aarch64 topic:stdlib:crypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @beta-ziliani