-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise error when passed invalid config file path #393
Merged
veelenga
merged 5 commits into
crystal-ameba:master
from
stufro:362-raise-on-invalid-config-file-path
Jul 26, 2023
Merged
Raise error when passed invalid config file path #393
veelenga
merged 5 commits into
crystal-ameba:master
from
stufro:362-raise-on-invalid-config-file-path
Jul 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stufro
commented
Jul 24, 2023
veelenga
reviewed
Jul 24, 2023
stufro
force-pushed
the
362-raise-on-invalid-config-file-path
branch
from
July 24, 2023 18:10
d0554a1
to
5f878fb
Compare
veelenga
reviewed
Jul 25, 2023
Applied suggestion from PR Co-authored-by: Vitalii Elenhaupt <[email protected]>
stufro
force-pushed
the
362-raise-on-invalid-config-file-path
branch
from
July 25, 2023 07:43
0c431fc
to
d9b2d69
Compare
veelenga
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last minor comment. The rest of the changes LGTM
veelenga
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #362
I'm new here, let me know if you think this could be done in a different place/better way.