Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error when passed invalid config file path #393

Merged

Conversation

stufro
Copy link
Contributor

@stufro stufro commented Jul 24, 2023

Resolves #362

I'm new here, let me know if you think this could be done in a different place/better way.

spec/ameba/cli/cmd_spec.cr Outdated Show resolved Hide resolved
src/ameba/cli/cmd.cr Outdated Show resolved Hide resolved
@stufro stufro force-pushed the 362-raise-on-invalid-config-file-path branch from d0554a1 to 5f878fb Compare July 24, 2023 18:10
spec/ameba/config_spec.cr Outdated Show resolved Hide resolved
src/ameba/config.cr Outdated Show resolved Hide resolved
Applied suggestion from PR

Co-authored-by: Vitalii Elenhaupt <[email protected]>
@stufro stufro force-pushed the 362-raise-on-invalid-config-file-path branch from 0c431fc to d9b2d69 Compare July 25, 2023 07:43
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last minor comment. The rest of the changes LGTM

spec/ameba_fixture.yml Outdated Show resolved Hide resolved
@veelenga veelenga requested a review from Sija July 25, 2023 08:35
Copy link
Member

@veelenga veelenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@veelenga veelenga merged commit 8ef588d into crystal-ameba:master Jul 26, 2023
4 checks passed
@stufro stufro deleted the 362-raise-on-invalid-config-file-path branch July 26, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providing invalid config file path should raise instead of silently ignoring it
3 participants