Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logs and user messages: use "serialize" and "parse" instead of marshal/unmarshal #3240

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 16, 2024

This should make the errors easier to understand. I almost proposed "encode" instead of "serialize" but it would be more ambiguous.

@mmetc mmetc added this to the 1.6.4 milestone Sep 16, 2024
Copy link

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@mmetc mmetc added kind/enhancement New feature or request and removed needs/kind needs/area labels Sep 16, 2024
@mmetc mmetc changed the title logs and user messages: use "parse" and "serialize" instead of marshal/unmarshal logs and user messages: use "serialize" and "parse" instead of marshal/unmarshal Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 9.58904% with 66 lines in your changes missing coverage. Please review.

Project coverage is 51.29%. Comparing base (1591a0c) to head (86a7358).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/climachine/machines.go 0.00% 4 Missing ⚠️
cmd/crowdsec-cli/clinotifications/notifications.go 0.00% 4 Missing ⚠️
cmd/crowdsec-cli/clibouncer/bouncers.go 0.00% 3 Missing ⚠️
cmd/crowdsec-cli/cliconsole/console.go 0.00% 3 Missing ⚠️
cmd/crowdsec-cli/config_show.go 0.00% 3 Missing ⚠️
pkg/apiserver/papi.go 0.00% 3 Missing ⚠️
pkg/leakybucket/overflows.go 0.00% 3 Missing ⚠️
cmd/crowdsec-cli/clialert/alerts.go 0.00% 2 Missing ⚠️
cmd/crowdsec-cli/clihub/items.go 0.00% 2 Missing ⚠️
cmd/crowdsec-cli/clisimulation/simulation.go 0.00% 2 Missing ⚠️
... and 31 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3240   +/-   ##
=======================================
  Coverage   51.28%   51.29%           
=======================================
  Files         355      355           
  Lines       38839    38839           
=======================================
+ Hits        19919    19922    +3     
+ Misses      16956    16952    -4     
- Partials     1964     1965    +1     
Flag Coverage Δ
bats 40.88% <1.42%> (+0.06%) ⬆️
unit-linux 34.70% <7.46%> (+0.01%) ⬆️
unit-windows 28.60% <8.21%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit ce085dc into master Sep 17, 2024
20 checks passed
@mmetc mmetc deleted the marshal-unmarshal branch September 17, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants