lint: enable (some) gocritic checks

[mmetc]

No description provided.

[github-actions]

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

• /area agent
• /area local-api
• /area cscli
• /area appsec
• /area security
• /area configuration

Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

[codecov]

Codecov Report

Attention: Patch coverage is 41.37931% with 51 lines in your changes missing coverage. Please review.

Project coverage is 51.26%. Comparing base (5f22c78) to head (5b484b6).

Files with missing lines	Patch %	Lines
pkg/apiserver/controllers/v1/decisions.go	0.00%	11 Missing ⚠️
cmd/crowdsec-cli/clihub/utils_table.go	25.00%	3 Missing ⚠️
pkg/database/utils.go	0.00%	2 Missing and 1 partial ⚠️
pkg/hubtest/nucleirunner.go	0.00%	3 Missing ⚠️
cmd/crowdsec-cli/climachine/machines.go	33.33%	2 Missing ⚠️
cmd/crowdsec-cli/climetrics/statacquis.go	0.00%	2 Missing ⚠️
cmd/crowdsec-cli/climetrics/statappsecengine.go	0.00%	2 Missing ⚠️
cmd/crowdsec-cli/climetrics/statbucket.go	0.00%	2 Missing ⚠️
cmd/crowdsec-cli/climetrics/statparser.go	0.00%	2 Missing ⚠️
cmd/crowdsec-cli/climetrics/statstash.go	0.00%	2 Missing ⚠️
... and 13 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3238      +/-   ##
==========================================
- Coverage   51.27%   51.26%   -0.01%     
==========================================
  Files         355      355              
  Lines       38839    38834       -5     
==========================================
- Hits        19915    19910       -5     
+ Misses      16958    16957       -1     
- Partials     1966     1967       +1     

Flag	Coverage Δ
bats	40.81% <29.41%> (-0.06%)	⬇️
unit-linux	34.68% <19.27%> (-0.01%)	⬇️
unit-windows	28.60% <13.25%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sabban]

lgtm