Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context propagation: pass context to NewAPIC() #3231

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Sep 13, 2024

No description provided.

@mmetc mmetc added the kind/enhancement New feature or request label Sep 13, 2024
@mmetc mmetc added this to the 1.6.4 milestone Sep 13, 2024
@mmetc mmetc requested a review from blotus September 13, 2024 08:31
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.28%. Comparing base (5196932) to head (fbfd36f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
cmd/crowdsec-cli/clipapi/papi.go 14.28% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3231      +/-   ##
==========================================
- Coverage   51.31%   51.28%   -0.03%     
==========================================
  Files         355      355              
  Lines       38847    38849       +2     
==========================================
- Hits        19933    19924       -9     
- Misses      16951    16958       +7     
- Partials     1963     1967       +4     
Flag Coverage Δ
bats 40.92% <44.44%> (-0.04%) ⬇️
unit-linux 34.68% <22.22%> (-0.01%) ⬇️
unit-windows 28.63% <20.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmetc mmetc merged commit be391a3 into master Sep 19, 2024
17 checks passed
@mmetc mmetc deleted the context-propagation-2 branch September 19, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request needs/area
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants