Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable linters: copyloopvar, intrange #3184

Merged
merged 3 commits into from
Sep 17, 2024
Merged

enable linters: copyloopvar, intrange #3184

merged 3 commits into from
Sep 17, 2024

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Aug 22, 2024

avoid unnecessary/unused variables in new code

@mmetc mmetc added this to the 1.6.4 milestone Aug 22, 2024
Copy link

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.28%. Comparing base (f97b9c8) to head (29689ea).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3184   +/-   ##
=======================================
  Coverage   51.27%   51.28%           
=======================================
  Files         355      355           
  Lines       38839    38839           
=======================================
+ Hits        19916    19918    +2     
+ Misses      16959    16956    -3     
- Partials     1964     1965    +1     
Flag Coverage Δ
bats 40.88% <66.66%> (+0.01%) ⬆️
unit-linux 34.68% <83.33%> (-0.01%) ⬇️
unit-windows 28.60% <85.71%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sabban sabban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mmetc mmetc merged commit 5f22c78 into master Sep 17, 2024
17 checks passed
@mmetc mmetc deleted the 1.6.4-newlinters branch September 17, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants