Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cscli): add env variable flag for dashboard setup #3110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quantumsheep
Copy link

Hey!

I'm using nginx-proxy which works by reading the environment variables of a container to generate nginx configuration.

These changes adds a --env/-e option to cscli dashboard setup. The arguments are then forwarded to the container creation config.

Thanks,

Copy link

github-actions bot commented Jul 5, 2024

@quantumsheep: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind refactoring
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

Copy link

github-actions bot commented Jul 5, 2024

@quantumsheep: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area appsec
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@quantumsheep
Copy link
Author

/area cscli

@quantumsheep
Copy link
Author

/area configuration

@quantumsheep
Copy link
Author

/kind enhancement

@github-actions github-actions bot added kind/enhancement New feature or request and removed needs/kind labels Jul 5, 2024
@quantumsheep
Copy link
Author

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Jul 5, 2024

Hey 👋🏻 Thank you for your contribution, we have just feature locked 1.6.3 so we will pushed these for 1.6.4. However, note we plan to deprecate the cscli dashboard command as of 1.7.0

Edit: Ohhh you just saw and closed, we can merge but keep in mind the command will be useable if people want to keep a local cscli binary just for dashboard.

@quantumsheep quantumsheep reopened this Jul 5, 2024
@quantumsheep
Copy link
Author

Ok then I reopen them!

@LaurenceJJones LaurenceJJones added this to the 1.6.4 milestone Jul 5, 2024
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 3.70370% with 26 lines in your changes missing coverage. Please review.

Project coverage is 49.84%. Comparing base (ea2098f) to head (654400a).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/metabase/container.go 0.00% 13 Missing ⚠️
pkg/metabase/metabase.go 0.00% 12 Missing ⚠️
cmd/crowdsec-cli/dashboard.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3110      +/-   ##
==========================================
- Coverage   49.86%   49.84%   -0.02%     
==========================================
  Files         321      321              
  Lines       37667    37670       +3     
==========================================
- Hits        18781    18776       -5     
- Misses      17060    17069       +9     
+ Partials     1826     1825       -1     
Flag Coverage Δ
bats 38.45% <3.84%> (+0.05%) ⬆️
unit-linux 34.42% <0.00%> (-0.03%) ⬇️
unit-windows 29.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants