Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

385: send event when resource is available to use #392

Closed
wants to merge 1 commit into from
Closed

385: send event when resource is available to use #392

wants to merge 1 commit into from

Conversation

malachiobadeyi
Copy link

Description of your changes

This PR is a suggested approach for issue #385. The change uses annotation to track if an event notifying that the external resource is available, has been created/sent . If a resource is "Available" and an event has not been sent the reconcile will create/send an event. I have not had any feedback regarding issue 385 so I thought this may be a good way of getting the discussion going if the issue was not clear.

Fixes #385:

I have:

  • [x ] Read and followed Crossplane's contribution process.
  • [x ] Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

I have added new tests testing that the annotation is added on the creation and the event is sent in the correct scenarios.

@JSainsburyPLC JSainsburyPLC closed this by deleting the head repository Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send and event once an external resource is created and ready to use
2 participants