Allow URLs with multiple slashes to match router rules #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A URL such as ///x//y/z can now match router rule
get -> 'x', 'y', 'z' { }
as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A URL such as ///x//y/z can now match router rule
get -> 'x', 'y', 'z' { }
as expected.
It is common for URLs to inadvertently end up with multiple "/". When this happens, router rules that previously matched, no longer match. For example "/x/y/z" would match, but "//x/y/z" would not.
The patch squishes multiple "/" when parsing the request. If there is a better location for this logic please let me know and I'll try to apply it there.