Catch URI parse errors during routing #114
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis says:
|
|
Not sure anymore. |
jnthn
reviewed
Oct 6, 2020
lib/Cro/HTTP/Router.pm6
Outdated
| @@ -231,6 +231,12 @@ module Cro::HTTP::Router { | |||
| my @*BIND-FAILS; | |||
| my $log-timeline-task = $request.annotations<log-timeline>; | |||
| my $routing-outcome = Cro::HTTP::LogTimeline::Route.log: $log-timeline-task, -> { | |||
| CATCH { | |||
| when X::Cro::Uri::ParseError { | |||
| emit Cro::HTTP::Response.new(:500status, :$request); | |||
There was a problem hiding this comment.
I think it should be 400 (Bad Request), since it's the client's fault.
|
The failure is this:
I wonder where we've ended up with that being called. |
|
The problem being that 2019.03 is pre-rename, so has no |
No idea :). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is the best way to go about this, but...