Skip to content

Commit

Permalink
fix: get_route_maps not working starting 202211
Browse files Browse the repository at this point in the history
Let's stop doing crappy hack, and use a proper query instead :)
  • Loading branch information
kpetremann committed Oct 3, 2024
1 parent 9150238 commit d87dfd3
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 11 deletions.
12 changes: 2 additions & 10 deletions _modules/sonic.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,16 +811,8 @@ def get_route_maps():
"FABRIC-IN",
]
"""
# for now we only need the name of the route-maps, ? is a small hack
route_map = __salt__["cmd.run"]("show route-map ?", "").split("\n")

# doing some cleaning
del route_map[2]
del route_map[1]
del route_map[0]
route_map = [r.strip() for r in route_map]

return route_map
cmd = "vtysh -c 'show route-map' | awk '/route-map/ {print $2}' | sort -u"
return __salt__["cmd.shell"](cmd).split("\n")


def _upload_candidate_bgp_config(remote_tmpfile, content):
Expand Down
2 changes: 1 addition & 1 deletion _states/sonic.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def managed(name, templates, context=None, saltenv="base", reload_conf=False):
return ret


def add_user(name, password, public_keys, groups, gid=None, clear_password=True):
def add_user(name, password, public_keys, groups, gid=None, clear_password=True): # noqa: R0917
"""Add user.
To avoid issues, users must have at least a password or a ssh key.
Expand Down

0 comments on commit d87dfd3

Please sign in to comment.