docs: update

creative-introvert · Jun 14, 2024 · 5ced554 · 5ced554
1 parent f6e3b02
commit 5ced554
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 90 deletions.
diff --git a/workspace/examples/src/as-library/simple.ts b/workspace/examples/src/as-library/simple.ts
diff --git a/workspace/tons-of-tests-cli/src/diff.ts b/workspace/tons-of-tests-cli/src/diff.ts
@@ -30,14 +30,11 @@ export const _diff = <I = unknown, O = unknown, T = unknown>({
         );
         const hasResults = yield* repository.hasResults(currentTestRun);
 
-        // FIXME: void type cast
+        // FIXME: avoid type cast
         const previousTestRun = (yield* getPreviousTestRunResults(
             testSuite,
         )) as P.Option.Option<PT.Test.TestRunResults<I, O, T>>;
 
-        // FIXME: I can't filter before runCollectRecord, as
-        // I need to calculate the stats first. Not sure how
-        // to do this better.
         const filterUnchanged =
             (previous: P.Option.Option<PT.Test.TestRunResults>) =>
             ({

diff --git a/workspace/tons-of-tests-cli/src/summarize.ts b/workspace/tons-of-tests-cli/src/summarize.ts
@@ -44,6 +44,8 @@ const andTags = Options.text('all-tags').pipe(
     Options.withDescription('Filter tags (AND).'),
 );
 
+// TEST: summarize --labels doesn't affect the db (i.e. same test results are stored)
+// TEST: summarize --run -> commit -> summarize --run is idempotent
 export const _sumarize = <I = unknown, O = unknown, T = unknown>({
     labels: maybeLabels,
     orTags: maybeOrTags,
@@ -113,6 +115,7 @@ export const _sumarize = <I = unknown, O = unknown, T = unknown>({
             }).pipe(
                 P.Effect.flatMap(PT.Test.runCollectRecord(currentTestRun)),
                 P.Effect.tap(P.Effect.logDebug('from run')),
+                P.Effect.map(filter),
             );
 
         const getFromCache = () =>
@@ -121,12 +124,13 @@ export const _sumarize = <I = unknown, O = unknown, T = unknown>({
                 .pipe(
                     PT.Test.runCollectRecord(currentTestRun),
                     P.Effect.tap(P.Effect.logDebug('from cache')),
+                    P.Effect.map(filter),
                 );
 
         const testRun: PT.Test.TestRunResults = yield* P.Effect.if(
             shouldRun || !hasResults,
             {onTrue: getFromRun, onFalse: getFromCache},
-        ).pipe(P.Effect.map(filter));
+        );
 
         yield* P.Effect.logDebug('testRun');