only return an empty string if setEmptyValues is set #1484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angrybrad
deleted the
bugfix/cms-15331-adjustment-for-dropdown-and-empty-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When importing into a Dropdown field that doesn’t have an empty string as a valid option and the value provided in the feed is an empty string - only use it if
setEmptyValuesis set. Otherwise, treat the value asnulland allow the field to handle the fallback.This is less visible in v4 and Feed Me v5, but it can become a bit of a nuisance in v5 and Feed Me v6 when importing into a dropdown field inside a matrix field that’s set to the cards (or index) view.
Related issues
#15331