Bugfix/1481 assets field filename dont import #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW, I was seeing an error on import using filename to match to existing assets. I was made aware of this PR and gave it a test. I was seeing dozens if not hundreds of errors and in testing this fix all seemed to be processed as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When importing into the Assets field and creating assets from URL, the “Use this filename for assets created from URL:” can be set to “don’t import” or be empty for some fields. In a case like this, we should proceed with the “original” filename and don’t throw an error.
Also, removed “Use default” as a dropdown option for “Use this filename for assets created from URL:”.
Related issues
#1481