Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle entrified categories and tags fields #1346

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

i-just
Copy link
Contributor

@i-just i-just commented Jul 4, 2023

Description

If Categories or Tags have been entrified, the fields could have been changed to Entries field, but the feed still refers to them by their original type. Because of that, check if the field we got by handle matches the type saved in the feed, and if it doesn’t, use the Entries field type.

Once the feed is saved after entrification, the field type gets updated, so the code that changes the field type won’t be executed anymore.

(Just for Craft 4.)

Related issues

#1340

@i-just i-just requested a review from angrybrad as a code owner July 4, 2023 13:12
@angrybrad angrybrad merged commit b439f86 into develop Jul 6, 2023
5 checks passed
@angrybrad angrybrad deleted the bugfix/1340-entrified-fields branch July 6, 2023 23:08
angrybrad added a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants