[4.x] Shipping method performance issue due to order serialization. #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the expiration date of the Dummy payment gateway's dummy credit card to be several years in the future, it currently requires manually changing the year on every use due to being in the past.
Change expiration year handling to be the same as the latest version of commerce's handling
Update Dummy.php expiry date in 3.x
…ing-method-performance
Serialising the order toArray every time the evaluation needed is too costly with a large number of rules
lukeholder
changed the title
|
Please see #3653 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered this is the performance issue from blackfire profiling.