[Missing Tokens] Write Directly to Spellbook File #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentrexha
approved these changes
May 30, 2023
There was a problem hiding this comment.
Worked like a charm! Thanks, Ben! New PR using the new code: duneanalytics/spellbook#3444
Left a minor test suggestion.
Comment on lines
+9
to
+31
| test_file = "./out/test_file.txt" | ||
| try: | ||
| os.mkdir("./out") | ||
| open(test_file, "x") | ||
| except FileExistsError: | ||
| pass | ||
|
|
||
| f = open(test_file, "a") | ||
| file_lines = ["First Line\n", "Second Line\n"] | ||
| f.write("".join(file_lines)) | ||
| f.close() | ||
|
|
||
| with open(test_file, "r", encoding="utf-8") as file: | ||
| self.assertEqual(file_lines, file.readlines()) | ||
|
|
||
| for i, old_line in enumerate(file_lines): | ||
| new_line = f"New Line {i + 1}\n" | ||
| replace_line(old_line, new_line, test_file) | ||
|
|
||
| file_lines[i] = new_line | ||
| with open(test_file, "r", encoding="utf-8") as file: | ||
| self.assertEqual(file_lines, file.readlines()) | ||
| os.remove(test_file) |
There was a problem hiding this comment.
In my opinion, separating these three different use cases into separate methods for each case makes them easier to understand and maintain. What's your take on that?
There was a problem hiding this comment.
Ya sure --- this isn't really a production product, but I could go and spend more time fixing this. Could be several days before I get back to that.
There was a problem hiding this comment.
Not gonna do that now. I need to start using this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just set the
SPELLBOOK_PATHenv var and away you go!Once we merge this it will be: