New handler deployments #91
Conversation
There was a problem hiding this comment.
In general it looks good with a small caveat (see not-comment-related comment 🙂).
The bytecode when building on my local machine matches what I see onchain for all addresses.
Readme update is consistent with the new addresses.
networks.json is consistent with the output of the new script (with caveat).
networks.json
Outdated
| "transactionHash": "0xc6bf5d7b6a1e41025c2bb04e318bce909a98eff5cfd615200a872375a12eaf4d" | ||
| }, | ||
| "42161": { | ||
| "address": "0x6cF1e9cA41f7611dEf408122793c358a3d11E5a5", |
There was a problem hiding this comment.
For some strange reason, if I generate the networks file with this script I get that all addresses on 42161 are fully lowercase. My guess is that Foundry's behavior changed from checksummed to non-checksummed addresses (in fact Arbitrum is the latest chain to be deployed in Deployment1 and all deployments in Deployment2 are fully lowercase).
Even if locally inconsistent, I'll keep this file consistent with the output of the script that generates this file to avoid future confusion.
Co-authored-by: Federico Giacon <[email protected]>
|
As this is related only to deployment addresses, merging with 1 review. |
Description
Redeploys handlers to correctly respect the watch-tower interface.
Changes
networks.jsonnetworks.jsonHow to test