Add BitBadges #5324
Add BitBadges #5324
Conversation
| "images": [ | ||
| { | ||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/bitbadges/images/bitbadgeslogo.png", | ||
| "svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/bitbadges/images/bitbadgeslogo.svg" |
There was a problem hiding this comment.
the png and the svg are not visually idendical, and therefore cannot be placed inside the image object. You may have two image objects in the array.
There was a problem hiding this comment.
This was not resolved
There was a problem hiding this comment.
I recommend using the version without text, as it will not be readable >99% of the time.
| "website": "https://bitbadges.io/", | ||
| "pretty_name": "BitBadges", | ||
| "chain_id": "bitbadges-1", | ||
| "bech32_prefix": "cosmos", |
There was a problem hiding this comment.
The bech32 prefix is taken.... I think it's not allowed to be the same.
|
I resolved the previous comments made except for the bech32 Cosmos prefix one. I actually didn't realize the unique bech32 prefix was a requirement, so I will have to work towards changing it in the next chain update. Would you want me to remove the field / leave empty and edit when updated? Keep it as "cosmos" for now? Or, should I just revisit this PR when the fix goes live? |
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/bitbadges/images/bitbadgeslogo.png", | ||
| "svg": "https://raw.githubusercontent.com/cosmos/chain-registry/master/bitbadges/images/bitbadgeslogo.svg" | ||
| }, | ||
| "coingecko_id": "", |
There was a problem hiding this comment.
Please remove fields with empty strings
| "linux/amd64": "https://github.com/BitBadges/bitbadgeschain/releases/download/v1.0-mainnet/bitbadgeschain-linux-amd64", | ||
| "linux/arm64": "https://github.com/BitBadges/bitbadgeschain/releases/download/v1.0-mainnet/bitbadgeschain-linux-arm64" | ||
| }, | ||
| "cosmos_sdk_version": "v0.50.8", |
There was a problem hiding this comment.
the "sdk" and "ibc" properties are also required. They describe the same version data.
| "linux/arm64": "https://github.com/BitBadges/bitbadgeschain/releases/download/v1.0-mainnet/bitbadgeschain-linux-arm64" | ||
| }, | ||
| "cosmos_sdk_version": "v0.50.8", | ||
| "ibc_go_version": "v8.3.2", |
There was a problem hiding this comment.
the "sdk" and "ibc" properties are also required. They describe the same version data.
I suppose we can proceed for now |
This pull requests adds support for the BitBadges blockchain which just went live.