Pass labels from asset list to asset-list-item #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labels can not be changed and the items always use the default values. They need to be passed from the list. This is the quick solution i found but there might be more elegant ones. besides, I'm thinking button intent should be customizable too... Or the entire button. I'm open to hear sugestions and if I have time I'll try to submit a PR.
yyyyaaa
requested changes
May 19, 2024
| @@ -65,6 +65,8 @@ export default function AssetList(props: AssetListProps) { | |||
| showWithdraw={item.showWithdraw} | |||
| onDeposit={() => item?.onDeposit()} | |||
| onWithdraw={() => item?.onWithdraw()} | |||
| withdrawLabel={item.withdrawLabel ?? AssetListItem.defaultProps.withdrawLabel} | |||
There was a problem hiding this comment.
looks good, but I don't think you need the last bit ?? AssetListItem.defaultProps.withdrawLabel, AssetListItem already has default props for those :) remove those and I'll get it published
There was a problem hiding this comment.
done. thanks for the review
|
@faneaatiku published in 1.23.13, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labels can not be changed and the items always use the default values. They need to be passed from the list. This is the quick solution i found but there might be more elegant ones.
besides, I'm thinking button intent should be customizable too... Or the entire button. I'm open to hear sugestions and if I have time I'll try to submit a PR.