-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fixing and Adding Tutorials to Pages #766
base: master
Are you sure you want to change the base?
Conversation
[diff-counting] Significant lines: 1096. This diff might be too big! Developer leads are invited to review the code. |
Great work so far :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great so far! When I tested the student tutorial, the class I was on had no current office hour sessions, so the third and fourth pop ups appeared in the middle of the screen as shown in the image below. I'm not sure what the expected behavior is for this case.
Also, the last step highlighted the notification icon instead of the question mark.
Summary
Continuing the tutorials feature from last semester by merging the alex/tutorial branch into this one. Working on styling and adding the workflow for student, ta, and professor tutorials.
TODO:
Test Plan
Notes
Need to make sure all code changes are necessary (still a work in progress) -> clean up code (condense into one tutorial file)
Breaking Changes
None