Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flutter data model + new admin features #214

Merged
merged 33 commits into from
May 1, 2024

Conversation

neketka
Copy link
Collaborator

@neketka neketka commented Apr 29, 2024

Summary

This pull request updates the flutter data model to retrieve the latest changes from the server. Achievements are now editable form the admin frontend. We also have some useful new features like duplication and moving on admin frontend.

  • Automatic refresh of events on flutter side
  • Achievement admin page
  • Change challenge completed logic + new challenge logic to accomodate existing player
  • Achievement tracker updates
  • Connect achievement trackers to frontend

Test Plan

All journeys load as usual.

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 29, 2024

[diff-counting] Significant lines: 1383. This diff might be too big! Developer leads are invited to review the code.

@neketka neketka marked this pull request as ready for review April 30, 2024 01:33
Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved all issues (talked through in person and on Slack). Achievements are fully working, so are real time event updates on the flutter side.

Only thing that doesn't work yet is updating event trackers upon adding a new challenge to an existing completed event. This isn't really necessary for internal launch though and the other changes in this PR need to be merged in asap. We can continue working on this feature in a later PR.

@neketka neketka merged commit 2fc02e6 into master May 1, 2024
12 checks passed
@neketka neketka deleted the nikita/admin-and-data-fixes branch May 1, 2024 02:48
@jasmineee-li
Copy link
Contributor

The achievement tracking functions and logic for completeChallenge LGTM! I just finished some e2e tests for achievement tracker and tested -- they all run successfully. I added the tests to a new PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants