Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ta375/edit profile #210

Merged
merged 9 commits into from
Apr 28, 2024
Merged

Ta375/edit profile #210

merged 9 commits into from
Apr 28, 2024

Conversation

3TTemi
Copy link
Contributor

@3TTemi 3TTemi commented Apr 25, 2024 •
edited by cathli66
Loading

Summary

This pull request completes the edit profile page, allowing Cornell (Google) users to change their username, major, college, and graduation year.

  • Update UI to match new designs
  • Create edit profile page - button should only appear for non-guests
  • Connect edit profile to backend
  • Adds major and college fields to user schema

Breaking Changes

  • Adds major and college to db!

@3TTemi 3TTemi marked this pull request as draft April 25, 2024 02:55
@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 25, 2024 •
edited
Loading

[diff-counting] Significant lines: 574.

@cathli66 cathli66 marked this pull request as ready for review April 26, 2024 04:14
@neketka neketka merged commit 84335b4 into master Apr 28, 2024
12 checks passed
@neketka neketka deleted the ta375/edit-profile branch April 28, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neketka neketka neketka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@3TTemi @dti-github-bot @neketka @cathli66