Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link disconnect/connect events to navigation #203

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Conversation

neketka
Copy link
Collaborator

@neketka neketka commented Apr 22, 2024

Summary

This pull request connects the disconnect and connect events to the navigation system so that the state of the app accurately reflects connection status.

  • Loading screen for relog attempt
  • Disconnect navigates to SplashPage
  • Connect navigates to BottomNavBar
  • Add hot reload to backend using docker compose watch
  • Fix setting username for google login

Test Plan

Test login, logout, and server crash

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 22, 2024

[diff-counting] Significant lines: 220.

@neketka neketka marked this pull request as ready for review April 24, 2024 16:16
@neketka neketka requested a review from cathli66 April 24, 2024 16:16
@neketka neketka enabled auto-merge (squash) April 24, 2024 16:17
Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good! Thanks for the explanation :)

@neketka neketka merged commit deda168 into master Apr 24, 2024
12 checks passed
@neketka neketka deleted the nikita/fix-disconnect branch April 24, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants