Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byl8/images backend #201

Merged
merged 16 commits into from
Apr 26, 2024
Merged

Byl8/images backend #201

merged 16 commits into from
Apr 26, 2024

Conversation

BrianLa0616
Copy link
Contributor

Summary

This pull request is the first step towards implementing feature Foo

  • Added images in challenges, journeys, and gameplay page

Depends on #{number of PR}

Test Plan

image image

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 21, 2024

[diff-counting] Significant lines: 191.

Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images work on challenges journeys and gameplay! They also show up on the completed challenges page but don't look right. Could you also connect the images in the profile page too? Thanks :)
image
image

@cathli66
Copy link
Contributor

Also, can you change this line in completed_challenges_page.dart? There's a bug with location type that does not let you see the page otherwise

image

@BrianLa0616
Copy link
Contributor Author

Images work on challenges journeys and gameplay! They also show up on the completed challenges page but don't look right. Could you also connect the images in the profile page too? Thanks :) image image

Done. I also changed the footer because it was weird for me. Hopefully it doesn't break for you.

Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pictures are all working on my end! While testing, I also made some changes to the completed challenges UI to (hopefully) work well with any device.

@cathli66 cathli66 merged commit e0841ab into master Apr 26, 2024
12 checks passed
@cathli66 cathli66 deleted the byl8/images-backend branch April 26, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants