Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Byl8/challenge bug fix #199

Merged
merged 9 commits into from
Apr 21, 2024
Merged

Byl8/challenge bug fix #199

merged 9 commits into from
Apr 21, 2024

Conversation

BrianLa0616
Copy link
Contributor

Summary

Fix simple bug with names

  • Challenge challenge name to be event name

Test Plan

Screenshot 2024-04-21 at 3 21 08 PM

@dti-github-bot
Copy link
Member

dti-github-bot commented Apr 21, 2024 •
edited
Loading

[diff-counting] Significant lines: 26.

cathli66
cathli66 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@cathli66 cathli66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

friendlyLocation should probably be like friendlyDifficulty and include the enum values - I'll fix in my PR!

@cathli66 cathli66 merged commit 82c27b8 into master Apr 21, 2024
12 checks passed
@cathli66 cathli66 deleted the byl8/challenge-bug-fix branch April 21, 2024 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathli66 cathli66 cathli66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrianLa0616 @dti-github-bot @cathli66