tests/kola: add ext.config.networking.nm-ifcfg-rh-plugin test #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait for a review from @travier - so he can comment on what we should do for RHCOS9 and SCOS here. |
|
Well, I'm waiting on feedback on the RHCOS issue 😅. Let's wait for next week to see if we have objections. |
|
Can we add that check for RHCOS 9 too? We'll keep it for now. Thanks |
travier
reviewed
Mar 13, 2023
This test checks that the ifcfg-rh NetworkManager plugin is in the state we expect it to be in. Some more context in: - coreos#1993 - coreos#1991 - openshift/os#1022
dustymabe
force-pushed
the
dusty-kola-test
branch
from
db9fa35
to
b336013
Compare
travier
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test checks that the ifcfg-rh NetworkManager plugin is in the state we expect it to be in. Some more context in:
ifcfg-rhconfig support from NetworkManager openshift/os#1022