buildextend-installer: error out early if missing src config #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can entirely rip it out too... I went with the conservative approach so RHCOS doesn't have to carry that delta until it adopts the new installer. |
|
(What's interesting is that |
dustymabe
approved these changes
Jan 9, 2020
jlebon
force-pushed
the
pr/installer-not-supported
branch
from
f78d980
to
e507d55
Compare
In FCOS, we're looking to drop the installer ISO in favour of the live images: coreos/fedora-coreos-tracker#203 coreos/fedora-coreos-config#261 AFAIK, RHCOS should be able to follow suit once the new coreos-installer binary makes it there. Until then though, rather than entirely drop support for building it, at least check upfront that the `installer/` directory exists so we don't do a bunch of work for nothing.
jlebon
force-pushed
the
pr/installer-not-supported
branch
from
e507d55
to
c039b36
Compare
I actually hit that case while working on FCOSB since I did the obvious stuff and symlinked the |
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
plume: handle non-existent fcos releases.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In FCOS, we're looking to drop the installer ISO in favour of the live
images:
coreos/fedora-coreos-tracker#203
coreos/fedora-coreos-config#261
AFAIK, RHCOS should be able to follow suit once the new
coreos-installer binary makes it there.
Until then though, rather than entirely drop support for building it, at
least check upfront that the
installer/directory exists so we don'tdo a bunch of work for nothing.