-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADCIO-2907) feat: pub-sub add-to-cart #38
base: develop
Are you sure you want to change the base?
Conversation
const data = decodeURI(arg) | ||
.split("&") | ||
.reduce((acc, cur) => { | ||
const [key, value] = cur.split("="); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
URL 객체써서 요렇게 파싱하는건 어떠세요
const data = new URL(arg);
Object.fromEntries(data.searchParams)
@@ -102,6 +99,7 @@ export class Cafe24API implements ClientAPI { | |||
id: order_id, | |||
products: order_product.map((product) => ({ | |||
idOnStore: `${product.product_no}`, | |||
// categoryIdOnStore: `${product.category_no_1}`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
혹시 여기가 주석처리된 이유가 있을까요? 주석처리된 상태로 남겨둔다면, 간단히 이유를 남겨줘도 좋을 듯 해요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
우리가 원하는 카테고리(구매 플로우에서 처음에 접근한 상품분류 페이지)가 맞는지 확실하지 않아서 주석처리했습니다.
테스트해보고 주석 유지 여부 결정할게요. 아무래도 구매다보니 테스트가 쉽지 않네요 ..ㅎㅎ
✅ Jira Ticket Number
ADCIO-2907
♻️ Current situation
💡 Proposed solution
new AddToCartEvent(cart).dispatch()
같은 방법으로 간단하게 카트 이벤트를 pub합니다.action_basket
함수를 wrapping 했습니다.⚙️ Release Notes
➕ Additional Information
action_basket
함수 관련 수정이 있을 경우, 장바구니 수집에 문제가 생길 수 있습니다.🧪 Testing
🧑💻 Reviewer Nudging
✅ Checklist
📚 TODO