Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] Add azure to resource detection cloud list #423

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[otel-integration] Add azure to resource detection cloud list #423

merged 1 commit into from
Jun 26, 2024

Conversation

povilasv
Copy link
Contributor

Description

Fixes ES-302

How Has This Been Tested?

kind cluster doesn't throw any warnings ,so I assume it works.

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review June 26, 2024 11:12
@povilasv povilasv force-pushed the azure branch 2 times, most recently from c977149 to 82a2eb0 Compare June 26, 2024 11:27
matej-g
matej-g approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending the tests passing

@povilasv povilasv force-pushed the azure branch 9 times, most recently from 2ad652b to 2dfe40d Compare June 26, 2024 13:53
@povilasv povilasv merged commit 7eeceac into master Jun 26, 2024
7 checks passed
@povilasv povilasv deleted the azure branch June 26, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@royfur royfur royfur approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @matej-g @royfur