Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] add support for multline config #381

Merged
merged 1 commit into from
Mar 6, 2024
Merged

[otel-integration] add support for multline config #381

merged 1 commit into from
Mar 6, 2024

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Mar 6, 2024

Description

Add multiline configs for otel-integration

Fixes ES-12

How Has This Been Tested?

kind cluster

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv force-pushed the multiline-config branch 2 times, most recently from 2b8b713 to 572d1a7 Compare March 6, 2024 10:49
@povilasv povilasv marked this pull request as ready for review March 6, 2024 10:53
matej-g
matej-g approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good minus failing documentation CI

@povilasv povilasv merged commit 75d9f10 into master Mar 6, 2024
6 checks passed
@povilasv povilasv deleted the multiline-config branch March 6, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@royfur royfur royfur approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @matej-g @royfur