Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add helm lint to otel solutions #304

Merged
merged 1 commit into from
Oct 10, 2023
Merged

chore: add helm lint to otel solutions #304

merged 1 commit into from
Oct 10, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Oct 10, 2023 •
edited
Loading

Description

Fixes ES-57 also updated charts to pass lint.

How Has This Been Tested?

  • See CI results.

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv added the skip changelog Won't require a changelog update check to pass. label Oct 10, 2023
@povilasv povilasv marked this pull request as ready for review October 10, 2023 11:58
@povilasv povilasv merged commit 4163036 into master Oct 10, 2023
6 of 7 checks passed
@povilasv povilasv deleted the lint branch October 10, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
skip changelog Won't require a changelog update check to pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @matej-g