Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-infrastructure-collector] change subsystem attribute list #292

Merged
merged 1 commit into from
Sep 28, 2023
Merged

[otel-infrastructure-collector] change subsystem attribute list #292

merged 1 commit into from
Sep 28, 2023

Conversation

povilasv
Copy link
Contributor

Description

Remove k8s.job.name, k8s.container.name and k8s.node.name from subsystem attribute list

Fixes ES-103

How Has This Been Tested?

  • kind cluster

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review September 28, 2023 05:43
@povilasv povilasv merged commit b57677b into master Sep 28, 2023
4 of 5 checks passed
@povilasv povilasv deleted the remove-subsystem-attributes3 branch September 28, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@matej-g matej-g Awaiting requested review from matej-g

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@povilasv