Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-infrastructure-collector] Add CRD generation + MySQL preset #255

Closed
wants to merge 6 commits into from
Closed

[otel-infrastructure-collector] Add CRD generation + MySQL preset #255

wants to merge 6 commits into from

Conversation

matej-g
Copy link
Contributor

@matej-g matej-g commented Jul 17, 2023

Description

Resolves ES-29.

Adds new features necessary for MySQL preset to be added to otel-infrastructure-collector:

  • Adds CRD generation, to be used with OpenTelemetry Operator
  • Adds and configures MySQL preset
  • Documents both features in detail
  • Use our fork of OpenTelemetry chart to enable these features

How Has This Been Tested?

Locally on a cluster.

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@matej-g matej-g mentioned this pull request Jul 17, 2023
Closed
3 tasks
@matej-g
Copy link
Contributor Author

matej-g commented Jul 17, 2023

FYI to fully implement all missing improvements and metrics, we are still blocked on coralogix/opentelemetry-helm-charts#16 (comment).

@matej-g
Fix docs
bcb6277 
Signed-off-by: Matej Gera <[email protected]>
@matej-g matej-g marked this pull request as ready for review July 17, 2023 13:04
@matej-g matej-g marked this pull request as draft July 17, 2023 13:04
@matej-g
Copy link
Contributor Author

matej-g commented Aug 17, 2023

Superseded by #272, closing this one

@matej-g matej-g closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oded-dd oded-dd oded-dd left review comments

@povilasv povilasv povilasv approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matej-g @povilasv @oded-dd