Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-infrastructure-collector] add helm install ci test #254

Merged
merged 3 commits into from
Jul 17, 2023
Merged

[otel-infrastructure-collector] add helm install ci test #254

merged 3 commits into from
Jul 17, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Jul 17, 2023 •
edited
Loading

Description

Fixes ES-45 #

How Has This Been Tested?

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv force-pushed the feat-improve-ci-2 branch 3 times, most recently from e7af2f5 to 856f53b Compare July 17, 2023 09:55
@povilasv povilasv added the skip changelog Won't require a changelog update check to pass. label Jul 17, 2023
@povilasv povilasv force-pushed the feat-improve-ci-2 branch 2 times, most recently from 211c95e to a17f2c4 Compare July 17, 2023 11:03
@povilasv povilasv marked this pull request as ready for review July 17, 2023 12:56
matej-g
matej-g approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, two small suggestions

.github/workflows/helm-test.yml Show resolved Hide resolved
.github/workflows/otel-infra-helm-test.yml Outdated Show resolved Hide resolved
@povilasv povilasv merged commit 00f9baf into master Jul 17, 2023
2 of 3 checks passed
@povilasv povilasv deleted the feat-improve-ci-2 branch July 17, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
skip changelog Won't require a changelog update check to pass.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @matej-g