Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opentelemetry-collector] Allow setting spanmetrics namespace #104

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

povilasv
Copy link

Fix: ES-354

Allow setting spanmetrics metric namespace, and change default to empty.

To avoid the following breaking change:

spanmetricsconnector: Improve consistency between metrics generated by spanmetricsconnector. Added traces.span.metrics as default namespace (#33227, #32818) Default namespace for the generated metrics is traces.span.metrics now. | The deprecated metrics are: calls, duration and events. | The feature flag connector.spanmetrics.legacyLatencyMetricNames was added to revert the behavior.

@povilasv povilasv marked this pull request as ready for review September 12, 2024 06:15
Copy link
Collaborator

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povilasv povilasv merged commit 7961341 into main Sep 12, 2024
3 checks passed
@povilasv povilasv deleted the es-354-prefix branch September 12, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants