Groups accumulator for array_agg #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joroKr21
approved these changes
Apr 12, 2024
Dandandan
reviewed
Apr 16, 2024
| total_num_groups, | ||
| |group_index, new_value: ArrayRef| { | ||
| let new_value = new_value.as_primitive::<T>(); | ||
| self.values[group_index].append( |
There was a problem hiding this comment.
You probably want to use extend here in order to avoid collecting into Vec.
There was a problem hiding this comment.
e.g. self.values[group_index]. extend(new_value.into_iter())
Dandandan
reviewed
Apr 16, 2024
| |group_index, new_value: ArrayRef| { | ||
| let new_value = new_value.as_string::<i32>(); | ||
|
|
||
| self.values[group_index].append( |
joroKr21
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Groups accumulator for array_agg * small fix * fmt * clippy * clippy
joroKr21
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Groups accumulator for array_agg * small fix * fmt * clippy * clippy
joroKr21
pushed a commit
that referenced
this pull request
Jun 13, 2024
* Groups accumulator for array_agg * small fix * fmt * clippy * clippy
joroKr21
added a commit
that referenced
this pull request
Jun 24, 2024
* Add pool_size method to MemoryPool (#218) (#230) * Add pool_size method to MemoryPool * Fix * Fmt Co-authored-by: Daniël Heres <[email protected]> * Move FileSinkExec::metrics to the correct place (#239) * Groups accumulator for array_agg (#233) * Groups accumulator for array_agg * small fix * fmt * clippy * clippy * Fix clippy * Fix sink output schema being passed in to `FileSinkExec` where input schema was expected * Propagate CSV options (quote, double quote, and escape) through protos * Remove unused field from NthValue * Remove Sized constraint from ExecutionPlan::name --------- Co-authored-by: Daniël Heres <[email protected]> Co-authored-by: Gediminas Aleknavičius <[email protected]> Co-authored-by: svranesevic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache#10063