Optimize sleep in test/systemtests #1037
Conversation
|
build PR |
1 similar comment
|
build PR |
|
build PR |
5 similar comments
|
build PR |
|
build PR |
|
build PR |
|
build PR |
|
build PR |
|
@vhosakot |
|
build PR |
| @@ -510,19 +508,15 @@ func (s *systemtestSuite) TestBgpTriggerNetpluginRestart(c *C) { | |||
| for _, node := range s.nodes { | |||
| var err error | |||
| c.Assert(node.stopNetplugin(), IsNil) | |||
| logrus.Info("Sleeping for a while to wait for netplugin's TTLs to expire") | |||
| time.Sleep(1 * time.Minute) | |||
There was a problem hiding this comment.
This requires some checks to ensure whatever is meant to expire has expired. We can't remove these two sleep calls without ensuring the relevant TTL has expired. The BGP tests run into some failures right now.
| @@ -626,8 +620,7 @@ func (s *systemtestSuite) TestBgpMultiTrigger(c *C) { | |||
| ) | |||
| iter++ | |||
| c.Assert(nodeToStop.stopNetplugin(), IsNil) | |||
| logrus.Info("Sleeping for a while to wait for netplugin's TTLs to expire") | |||
| time.Sleep(2 * time.Minute) | |||
There was a problem hiding this comment.
This requires some checks to ensure the TTL has expired as well.
| @@ -735,12 +730,10 @@ func (s systemtestSuite) testServiceTriggerNetpluginRestart(c *C, encap string) | |||
| } | |||
| } | |||
| c.Assert(node.stopNetplugin(), IsNil) | |||
| logrus.Info("Sleeping for a while to wait for netplugin's TTLs to expire") | |||
| time.Sleep(2 * time.Minute) | |||
There was a problem hiding this comment.
This is similar - it needs some checks to ensure the TTLs have expired.
|
build PR |
3 similar comments
|
build PR |
|
build PR |
|
build PR |
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
Signed-off-by: Vikram Hosakote <[email protected]>
|
build PR |
Signed-off-by: Vikram Hosakote <[email protected]>
|
build PR |
Signed-off-by: Vikram Hosakote <[email protected]>
|
build PR |
There was a problem hiding this comment.
I think the poller logic should be in testing codes instead of client codes, and also can be a function with a func pointer (of get method, if possible) passed as a parameter, this would save some efforts on adding such function for each object.
also the checkListener loops, inspect loops might be all benefits from such util func
|
Since this has taken a long time, moving it to backlog, and I'm working on other high-priority Contiv tickets. Please do not close this PR. I'll work on it later when this PR gets higher priority. |
The Contiv system tests in
netplugin/test/systemtestscalltime.Sleep()151 times in code, many of them in loops. Due to this, the time needed to run these system tests is high. Netplugin CI needs 2.5 hours to run them.This PR optimizes and reduces the sleeps in system tests' code in the following areas:
contivModelClient.goto poll for the status of the objectsAppProfile,EndpointGroup,Global,Network,Ruleafter creating (httpPost) and deleting (httpDelete) them.AppProfile,EndpointGroup,Global,Network,Ruleafter creating and deleting them.Signed-off-by: Vikram Hosakote [email protected]