Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build binaries on publish for Linux and macOS #44

Closed
wants to merge 23 commits into from
Closed

Build binaries on publish for Linux and macOS #44

wants to merge 23 commits into from

Conversation

dkozma
Copy link

@dkozma dkozma commented Nov 17, 2023

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4bbc6b7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dkozma dkozma changed the title Add build workflow Build binaries on publish for Linux and macOS Nov 21, 2023
@dkozma dkozma marked this pull request as ready for review November 21, 2023 16:08
dkozma
dkozma commented Nov 21, 2023
View reviewed changes
.github/workflows/release-binaries.yml
Comment on lines +80 to +82
CARGO_TARGET_AARCH64_UNKNOWN_LINUX_GNU_LINKER: x86_64-w64-mingw32-gcc
CC_aarch64_unknown_linux_gnu: x86_64-w64-mingw32-gcc
CXX_aarch64_unknown_linux_gnu: x86_64-w64-mingw32-g++
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect but I can fix it once I enable windows builds

@dkozma
Copy link
Author

dkozma commented Feb 27, 2024

Superseded by #51.

@dkozma dkozma closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emensch emensch Awaiting requested review from emensch

@MassivaM MassivaM Awaiting requested review from MassivaM

@jackfarzan jackfarzan Awaiting requested review from jackfarzan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dkozma