Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add erdmannfreunde/theme-toolbox #504

Merged
merged 7 commits into from
Sep 28, 2023
Merged

add erdmannfreunde/theme-toolbox #504

merged 7 commits into from
Sep 28, 2023

Conversation

denniserdmann
Copy link
Contributor

No description provided.

Copy link
Collaborator

@xchs xchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some issues that should be addressed before this can be merged:

image

meta/erdmannfreunde/theme-toolbox/en.yml Outdated Show resolved Hide resolved
@xchs
Copy link
Collaborator

xchs commented Sep 26, 2023

@denniserdmann Could you please also add the following words to the German allowlist? Thank you.

image

@denniserdmann
Copy link
Contributor Author

@xchs Done!

@xchs
Copy link
Collaborator

xchs commented Sep 27, 2023

@xchs Done!

Where did you make your additions? Did you commit the changes?

@denniserdmann
Copy link
Contributor Author

see #506

@xchs
Copy link
Collaborator

xchs commented Sep 27, 2023

@denniserdmann The changes should be made for this PR. May I ask you that you commit your changes into this PR? Thanks.

@Toflar Toflar enabled auto-merge (squash) September 28, 2023 11:39
@Toflar Toflar merged commit e20ebcd into contao:main Sep 28, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants