Allow value 0 in includeBlankOption - fix issue 1022 #1716
Conversation
Allow value 0 in includeBlankOption - fix issue #1022 see contao/contao#1022 (comment)
|
I think we should add some tests for this change to see if it supports all edge cases. Plus I'd target this against master (4.11). I don't think we should risk breaking 4.4 onwards. |
|
Oh, and I didn't notice this before: You PR should target |
|
shit - can I change it online? I did the PR directly on gitlab... |
| @@ -1181,7 +1181,7 @@ public static function optionSelected($strOption, $varValues) | |||
| return ''; | |||
| } | |||
|
|
|||
| return (\is_array($varValues) ? \in_array($strOption, $varValues) : $strOption == $varValues) ? ' selected' : ''; | |||
| return \in_array($strOption, array_map('strval', (array) $varValues), true) ? ' checked' : ''; | |||
There was a problem hiding this comment.
Why did you change selected to checked here?
There was a problem hiding this comment.
I copy your code...
contao/contao#1022 (comment)
There was a problem hiding this comment.
I used your code from contao/contao#1022 (comment) as the basis.
But making a pull request with just a copy of my code doesn’t bring us much further. What we need to do is described here: contao/contao#1022 (comment)
There was a problem hiding this comment.
hmm something is on the wrong rail here - I'll check it again
|
Closed in favor of contao/contao#2350 |
|
I don't really understand why the PR is closed - so far the behaviour is unchanged... see https://github.com/menatwork/contao-multicolumnwizard-bundle/issues/63 - I would like to close that issue |
It was closed in favor of contao/contao#2350 |
|
entweder stehe ich auf dem Schlauch oder verstehe es nicht - warum ist #2350 geschlossen?!? das Problem ist bisher nicht gefixt! |
See contao/contao#2350 (comment) :
You can answer the open questions and address the comments to get it reopened. |
Allow value 0 in includeBlankOption - fix issue #1022
see contao/contao#1022 (comment)